-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for <input> without type
#141
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oh, I'm probably not aware of the deeper details and how
Sure, ok - after b6b4c5a I have |
@adamwathan Maybe this is what you mean by overriding? (added |
Yep exactly! As long as you can override any of the styles set by the plugin by adding a utility then we should be good 👍 |
Great, nice 👍 This also works with the Anything else that I should to do before this is ready to merge? |
Nope I think this looks good now, thank you! |
Great, glad to help :) Thanks for the guidance, review and merge! 🙌 |
@adamwathan (or @thecrypticace, @bradlc, @RobinMalfait) could this be published as a new release? (I'm guessing |
@karlhorky Yep we'll publish a release when we get a chance, no guarantees it'll be today but soon. In the mean time you can use the insiders build that is automatically published on every commit:
|
I published v0.5.4 so there's a proper tag now ✨ |
Great, thanks! |
I think this should have been a breaking change, it added borders to all our input fields, where the border wasn't present before. |
@abouroubi sorry to hear! To be clear, your |
No they did not have type attribute. |
Allow for
<input />
elements without thetype
attribute (eg. which defaults to a text input), which may be required by certain codebases:Also removed the note from the readme, which isn't required anymore if my approach works
Preview looks good - allows for overriding via A) utility classes and also B)
input
selector:Ref: